Skip to content

WIP: ext_authz: Use HTTP service URI#10573

Closed
dio wants to merge 5 commits intoenvoyproxy:masterfrom
dio:fix-ext_authz-service-uri
Closed

WIP: ext_authz: Use HTTP service URI#10573
dio wants to merge 5 commits intoenvoyproxy:masterfrom
dio:fix-ext_authz-service-uri

Conversation

@dio
Copy link
Copy Markdown
Member

@dio dio commented Mar 30, 2020

Description:

This is a WIP to use the configured HTTP Service server URI as authorization service target.

Risk Level: Low
Testing: Unit, TBA integration
Docs Changes: TBA
Release Notes: TBA
Fixes #5357
Fixes #10104

dio added 2 commits March 30, 2020 06:43
This patch enables the use of HTTP service URI.

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10573 was opened by dio.

see: more, trace.

dio added 3 commits March 30, 2020 07:09
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
// Settings used for controlling authorization response metadata.
AuthorizationResponse authorization_response = 8;

common.dynamic_forward_proxy.v2alpha.DnsCacheConfig dns_cache_config = 9;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comment explaining how this is supposed to be used? Thanks.

@stale
Copy link
Copy Markdown

stale Bot commented Apr 7, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale Bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 7, 2020
@htuch
Copy link
Copy Markdown
Member

htuch commented Apr 7, 2020

Please merge master to pick up #10672. We no longer accept changes to v2 (without explicit exception), so any API modifications should happen in v3. If this PR is adding a new proto, please follow the updated instructions in https://github.com/envoyproxy/envoy/blob/master/api/STYLE.md#adding-an-extension-configuration-to-the-api.

@stale stale Bot removed the stale stalebot believes this issue/PR has not been touched recently label Apr 7, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Apr 14, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale Bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 14, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Apr 23, 2020

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale Bot closed this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ext_authz ignores uri with http_service envoy.config.filter.http.ext_authz.v2.ExtAuthz as http_service does not use config uri

2 participants