docs: split consumed headers list based on request/response consumption#11200
Conversation
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
| x-envoy-decorator-operation | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Setting this header on egress requests, its value will override any locally defined |
There was a problem hiding this comment.
i rephrased this to start the paragraph the same way as the other header, but this one is a bit different to the others because it describes two different behavior depending on whether its a request/response.
It might be nicer to have this doc speak about downstream/upstream vs egress/ingress since I don't think the router actually cares about the ingress/egress distinction (beyond some trace tags)
There was a problem hiding this comment.
Agreed to you want to just fix that?
|
Can you check the docs build? /wait |
Signed-off-by: Snow Pettersen <aickck@gmail.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small comment, thanks.
/wait
| x-envoy-decorator-operation | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Setting this header on egress requests, its value will override any locally defined |
There was a problem hiding this comment.
Agreed to you want to just fix that?
Signed-off-by: Snow Pettersen <aickck@gmail.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, just a few typos I caught.
/wait
| ^^^^^^^^^^^^^^^^ | ||
|
|
||
| Setting this header on egress requests will cause Envoy to attempt to retry failed requests (number | ||
| Setting this header requests will cause Envoy to attempt to retry failed requests (number |
There was a problem hiding this comment.
| Setting this header requests will cause Envoy to attempt to retry failed requests (number | |
| Setting this header will cause Envoy to attempt to retry failed requests (number |
?
| Setting this header on egress requests will cause Envoy to use a request | ||
| hedging strategy in the case of a per try timeout. This overrides the value set | ||
| in the :ref:`route configuration | ||
| Setting this header on cause Envoy to use a request hedging strategy in the case of a per try timeout. |
There was a problem hiding this comment.
| Setting this header on cause Envoy to use a request hedging strategy in the case of a per try timeout. | |
| Setting this header will cause Envoy to use a request hedging strategy in the case of a per try timeout. |
?
2 participants
Signed-off-by: Snow Pettersen kpettersen@netflix.com
Commit Message: Splits the documentation for consumed headers on the router to differentiate between requests consumed from the downstream request versus the upstream response.