Skip to content

Correct error method name in DynamicRouteEntry#11282

Merged
htuch merged 3 commits into
envoyproxy:masterfrom
wbpcode:fix-route
May 26, 2020
Merged

Correct error method name in DynamicRouteEntry#11282
htuch merged 3 commits into
envoyproxy:masterfrom
wbpcode:fix-route

Conversation

@wbpcode
Copy link
Copy Markdown
Member

@wbpcode wbpcode commented May 21, 2020

Signed-off-by: wbpcode comems@msn.com

I am not sure if this is a mistake. If this is a feature rather than an error, please turn off this PR directly.

Signed-off-by: wbpcode <comems@msn.com>
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the fix @wbpcode, this looks like maybe a copy+paste error. Would you be able to add or modify a simple unit test that validates this? No need for anything more heavyweight.

Signed-off-by: wbpcode <comems@msn.com>
@wbpcode
Copy link
Copy Markdown
Member Author

wbpcode commented May 23, 2020

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🤷‍♀️ nothing to rebuild.

🐱

Caused by: a #11282 (comment) was created by @wbpcode.

see: more, trace.

@wbpcode
Copy link
Copy Markdown
Member Author

wbpcode commented May 23, 2020

A unit test was added. But macos presubmit CI failed because of timeout. How can I re-execute CI without submitting a new commit? @htuch

@wbpcode
Copy link
Copy Markdown
Member Author

wbpcode commented May 25, 2020

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #11282 (comment) was created by @wbpcode.

see: more, trace.

@wbpcode
Copy link
Copy Markdown
Member Author

wbpcode commented May 26, 2020

It's ready now. @htuch

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 29ee320 into envoyproxy:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants