docs: clarify upstream_rq_pending_failure_eject stat #11315
Merged
mattklein123 merged 2 commits intoMay 26, 2020
Merged
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
mattklein123
approved these changes
May 26, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks. I agree this is confusing and this came up a few months ago at Lyft also (cc @tonya11en). I regret using the same stat for all of this but I'm not sure it's worth changing now.
Contributor
Author
|
No problem. I was thinking about proposing that change - but I agree it is not worth changing now , thats why I dropped that idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: clarify upstream_rq_pending_failure_eject stat
Additional Description: Refer #11237
Risk Level: N/A
Testing: N/a
Docs Changes: N/a
Release Notes: N/A
Fixes #11237