[fuzz] fix fuzz crashes related to not implemented protos#11385
Merged
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
htuch
reviewed
Jun 2, 2020
Signed-off-by: Asra Ali <asraa@google.com>
Member
|
Yeah, in general making PGV annotations more restrictive is bad, except for the case where this restriction is 100% in the existing contract, which it is in these cases :) |
htuch
reviewed
Jun 2, 2020
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Member
|
Looks like it's hitting the new extension coverage bar? /wait |
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
…#11385) Fixes crashes (panic: not reached) due to not implemented protos being fuzzed. - load balancing policy LOAD_BALANCING_POLICY_CONFIG not implemented, causing server_fuzz_test to crash - connect matcher not supported in Jwt authentication filter, but matcher available @qiwzhang Risk Level: Low Testing: Regression testcases added Fixes OSS-fuzz issues - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21876 - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17762 Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
…#11385) Fixes crashes (panic: not reached) due to not implemented protos being fuzzed. - load balancing policy LOAD_BALANCING_POLICY_CONFIG not implemented, causing server_fuzz_test to crash - connect matcher not supported in Jwt authentication filter, but matcher available @qiwzhang Risk Level: Low Testing: Regression testcases added Fixes OSS-fuzz issues - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21876 - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17762 Signed-off-by: Asra Ali <asraa@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
…#11385) Fixes crashes (panic: not reached) due to not implemented protos being fuzzed. - load balancing policy LOAD_BALANCING_POLICY_CONFIG not implemented, causing server_fuzz_test to crash - connect matcher not supported in Jwt authentication filter, but matcher available @qiwzhang Risk Level: Low Testing: Regression testcases added Fixes OSS-fuzz issues - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21876 - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17762 Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Commit Message: Fixes crashes (panic: not reached) due to not implemented protos being fuzzed.
Additional Description:
LOAD_BALANCING_POLICY_CONFIGnot implemented, causingserver_fuzz_testto crashRisk Level: Low
Testing: Regression testcases added
Fixes