Skip to content

fuzz: flip forwardClientCert option in HCM fuzz target#11496

Merged
mattklein123 merged 2 commits into
envoyproxy:masterfrom
samflattery:hcm_coverage
Jun 10, 2020
Merged

fuzz: flip forwardClientCert option in HCM fuzz target#11496
mattklein123 merged 2 commits into
envoyproxy:masterfrom
samflattery:hcm_coverage

Conversation

@samflattery
Copy link
Copy Markdown
Contributor

@samflattery samflattery commented Jun 8, 2020

Commit Message: Flip forwardClientCert option in HCM fuzz target
Additional Description:

  • add an extra field to the hcm fuzz config proto to also change the forwardClientCert option to increase fuzz coverage
  • add an extra argument to FuzzConfig's constructor to update the config

Risk Level: Low
Testing: ran with libfuzzer for 2 minutes
Docs Changes: N/A
Release Notes: N/A

Sam Flattery added 2 commits June 8, 2020 15:26
flip forwardClientCert option in HCM fuzz
f012023 
Signed-off-by: Sam Flattery <samflattery@google.com>
style fix
3af2621 
Signed-off-by: Sam Flattery <samflattery@google.com>
@samflattery
Copy link
Copy Markdown
Contributor Author

samflattery commented Jun 8, 2020

/cc @asraa

@asraa asraa self-assigned this Jun 8, 2020
asraa
asraa reviewed Jun 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very awesome! By any chance can you note a difference before and after this PR for coverage over conn_manager_utility.cc?

@samflattery
Copy link
Copy Markdown
Contributor Author

samflattery commented Jun 9, 2020

I just ran FUZZ_COVERAGE=true VALIDATE_COVERAGE=false test/run_envoy_bazel_coverage.sh //test/common/http:conn_manager_impl_fuzz_test_with_libfuzzer and it increased line coverage by .7% in source/common/http and increased the line coverage of a few of the conn_manager related files by a couple of percent. (conn_manager_impl.cc by 1%)

asraa
asraa approved these changes Jun 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All coverage gains are good gains :)

@mattklein123 mattklein123 merged commit c4a8b03 into envoyproxy:master Jun 10, 2020
@samflattery samflattery deleted the hcm_coverage branch June 19, 2020 10:07
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jun 24, 2020
@samflattery @yashwant121
fuzz: flip forwardClientCert option in HCM fuzz target (envoyproxy#11496
32c49be 
)

Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu pushed a commit to songhu/envoy that referenced this pull request Jun 25, 2020
@samflattery @songhu
fuzz: flip forwardClientCert option in HCM fuzz target (envoyproxy#11496
4fe1d67 
)

Signed-off-by: Sam Flattery <samflattery@google.com>
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
@samflattery @yashwant121
fuzz: flip forwardClientCert option in HCM fuzz target (envoyproxy#11496
a84b156 
)

Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
@samflattery @yashwant121
fuzz: flip forwardClientCert option in HCM fuzz target (envoyproxy#11496
a4c7ebe 
)

Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
@samflattery @yashwant121
fuzz: flip forwardClientCert option in HCM fuzz target (envoyproxy#11496
8bd9a34 
)

Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@asraa asraa asraa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asraa asraa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samflattery @asraa @mattklein123