integration test: Add DrainCloseIntegrationTest#11499
Merged
Merged
Conversation
added 4 commits
June 8, 2020 16:17
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
Author
|
A few notes:
|
alyssawilk
reviewed
Jun 9, 2020
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
I'd say if you intend to add shutdown tests that aren't drain close you can rename, otherwise I don't think you have to try to fugure proof
Signed-off-by: Auni Ahsan <auni@google.com>
Author
|
/azp run envoy-presubmit |
|
Commenter does not have sufficient privileges for PR 11499 in repo envoyproxy/envoy |
added 4 commits
June 9, 2020 18:34
Signed-off-by: Auni Ahsan <auni@google.com>
Signed-off-by: Auni Ahsan <auni@google.com>
alyssawilk
approved these changes
Jun 11, 2020
arthuryan-k
pushed a commit
to arthuryan-k/envoy
that referenced
this pull request
Jun 15, 2020
Description: groups drain close tests together Risk Level: n/a (test only) Signed-off-by: Auni Ahsan <auni@google.com> Signed-off-by: Arthur Yan <arthuryan@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
Description: groups drain close tests together Risk Level: n/a (test only) Signed-off-by: Auni Ahsan <auni@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Description: groups drain close tests together Risk Level: n/a (test only) Signed-off-by: Auni Ahsan <auni@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Description: groups drain close tests together Risk Level: n/a (test only) Signed-off-by: Auni Ahsan <auni@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: I wanted to group all of the tests related to drain close behaviour in one place, in preparation for adding additional test coverage and complexity (e.g. simulated time tests, new admin endpoint options).
Risk Level: Test only