Skip to content

health_check filter & readme: fix typos #11513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowp merged 1 commit into from
Jun 10, 2020
Merged

health_check filter & readme: fix typos #11513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions generated_api_shadow/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
This directory is for generated Envoy internal artifacts (via `proto_format`).

Do not hand edit any file under `envoy/`. This shadow API may only be used be
used in the Envoy source tree.
Do not hand edit any file under `envoy/`. This shadow API may only be used in
the Envoy source tree.

The `bazel/` tree is an symlink back to the official API Bazel rules.
The `bazel/` tree is a symlink back to the official API Bazel rules.
12 changes: 6 additions & 6 deletions test/extensions/filters/http/health_check/health_check_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,9 @@ TEST_F(HealthCheckFilterPassThroughTest, Ok) {
EXPECT_CALL(callbacks_, encodeHeaders_(_, _)).Times(0);
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->decodeHeaders(request_headers_, false));

Http::TestResponseHeaderMapImpl service_hc_respnose{{":status", "200"}};
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(service_hc_respnose, true));
EXPECT_EQ("cluster_name", service_hc_respnose.getEnvoyUpstreamHealthCheckedClusterValue());
Http::TestResponseHeaderMapImpl service_hc_response{{":status", "200"}};
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(service_hc_response, true));
EXPECT_EQ("cluster_name", service_hc_response.getEnvoyUpstreamHealthCheckedClusterValue());
}

TEST_F(HealthCheckFilterPassThroughTest, OkWithContinue) {
Expand All @@ -268,9 +268,9 @@ TEST_F(HealthCheckFilterPassThroughTest, OkWithContinue) {
filter_->encode100ContinueHeaders(continue_response));
Http::MetadataMap metadata_map{{"metadata", "metadata"}};
EXPECT_EQ(Http::FilterMetadataStatus::Continue, filter_->encodeMetadata(metadata_map));
Http::TestResponseHeaderMapImpl service_hc_respnose{{":status", "200"}};
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(service_hc_respnose, true));
EXPECT_EQ("cluster_name", service_hc_respnose.getEnvoyUpstreamHealthCheckedClusterValue());
Http::TestResponseHeaderMapImpl service_hc_response{{":status", "200"}};
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(service_hc_response, true));
EXPECT_EQ("cluster_name", service_hc_response.getEnvoyUpstreamHealthCheckedClusterValue());
}

TEST_F(HealthCheckFilterPassThroughTest, Failed) {
Expand Down