Subject: updating cel-cpp version used#11524
Merged
Merged
Conversation
lizan
reviewed
Jun 11, 2020
This is a prerequisite for porting envoy to c++17 as c++17 forbids the initialization of absl::string_view() with nullptr. The most recent patch of cel-cpp master fixes an instance of this issue. Signed-off-by: Yifan Yang <needyyang@google.com>
Contributor
Author
|
I have accidentally force pushed the commit with the change on the comment. Is this acceptable? Or should I submit a new one altogether. |
Contributor
No need for a new one. |
lizan
approved these changes
Jun 11, 2020
arthuryan-k
pushed a commit
to arthuryan-k/envoy
that referenced
this pull request
Jun 15, 2020
This is a prerequisite for porting envoy to c++17 as c++17 forbids the initialization of absl::string_view() with nullptr. The most recent patch of cel-cpp master fixes an instance of this issue. Signed-off-by: Yifan Yang <needyyang@google.com> Signed-off-by: Arthur Yan <arthuryan@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
This is a prerequisite for porting envoy to c++17 as c++17 forbids the initialization of absl::string_view() with nullptr. The most recent patch of cel-cpp master fixes an instance of this issue. Signed-off-by: Yifan Yang <needyyang@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
This is a prerequisite for porting envoy to c++17 as c++17 forbids the initialization of absl::string_view() with nullptr. The most recent patch of cel-cpp master fixes an instance of this issue. Signed-off-by: Yifan Yang <needyyang@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
This is a prerequisite for porting envoy to c++17 as c++17 forbids the initialization of absl::string_view() with nullptr. The most recent patch of cel-cpp master fixes an instance of this issue. Signed-off-by: Yifan Yang <needyyang@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for porting envoy to c++17 as c++17
forbids the initialization of absl::string_view() with nullptr.
The most recent patch of cel-cpp master fixes an instance of this
issue.
Signed-off-by: Yifan Yang needyyang@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level: Should be minimum as it just changes the version of an external dependency repo and all existing tests have been passed.
Testing: No new test should be needed.
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]