fuzz: Enabled "upgrade" request/response in fuzz test#11541
Merged
Conversation
Enabled "upgrade" option by adding an PEXPECT_CALL in conn_manager_impl_fuzz_test.cc. Covered functions: mutateRequestHeaders() and mutateResponseHeaders() with above changes. Signed-off-by: jianwen <jianwendong@google.com>
sqkerner
previously approved these changes
Jun 10, 2020
| })); | ||
| EXPECT_CALL(*decoder_filter_, setDecoderFilterCallbacks(_)); | ||
| EXPECT_CALL(*encoder_filter_, setEncoderFilterCallbacks(_)); | ||
| EXPECT_CALL(filter_factory_, createUpgradeFilterChain("WebSocket", _, _)) |
Signed-off-by: jianwen <jianwendong@google.com>
asraa
approved these changes
Jun 10, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks for adding the testcase!
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
Added test case with "upgrade" request/response in fuzz test. Enabled "upgrade" option by adding an EXPECT_CALL in conn_manager_impl_fuzz_test.cc. Fuzz test covers mutateRequestHeaders() and mutateResponseHeaders() with above changes. Signed-off-by: jianwen <jianwendong@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Added test case with "upgrade" request/response in fuzz test. Enabled "upgrade" option by adding an EXPECT_CALL in conn_manager_impl_fuzz_test.cc. Fuzz test covers mutateRequestHeaders() and mutateResponseHeaders() with above changes. Signed-off-by: jianwen <jianwendong@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Added test case with "upgrade" request/response in fuzz test. Enabled "upgrade" option by adding an EXPECT_CALL in conn_manager_impl_fuzz_test.cc. Fuzz test covers mutateRequestHeaders() and mutateResponseHeaders() with above changes. Signed-off-by: jianwen <jianwendong@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Enabled "upgrade" option by adding an PEXPECT_CALL() in conn_manager_impl_fuzz_test.cc.
Covered two functions: mutateRequestHeaders() and mutateResponseHeaders() with above
changes.
Signed-off-by: jianwen jianwendong@google.com
Risk Level: low
Testing: Covered mutateRequestHeaders() and mutateResponseHeaders() functions with above changes.
/cc @asraa
/cc @samkerner