upstreams: moving APIs to include#11555
Merged
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
changed the title
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM just one question.
/wait-any
Comment on lines
+605
to
+606
| auto pool = std::make_unique<TcpConnPool>(config_.cm_, *route_entry_, protocol, this); | ||
| if (pool->valid()) { |
Member
There was a problem hiding this comment.
This will eventually become a factory that can return null, right? If so this makes sense to me as a stop gap. Another option would be to just create a static factory for each type that can return null in this PR. Up to you.
Contributor
Author
There was a problem hiding this comment.
Exactly - the factory will return null - setting that PR up now :-)
mattklein123
approved these changes
Jun 11, 2020
arthuryan-k
pushed a commit
to arthuryan-k/envoy
that referenced
this pull request
Jun 15, 2020
Moving the Generic class definitions into the include file, in preparation for pluggable upstreams split out from envoyproxy#11327 Risk Level: Low (mostly only header changes) Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Arthur Yan <arthuryan@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
Moving the Generic class definitions into the include file, in preparation for pluggable upstreams split out from envoyproxy#11327 Risk Level: Low (mostly only header changes) Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Moving the Generic class definitions into the include file, in preparation for pluggable upstreams split out from envoyproxy#11327 Risk Level: Low (mostly only header changes) Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Moving the Generic class definitions into the include file, in preparation for pluggable upstreams split out from envoyproxy#11327 Risk Level: Low (mostly only header changes) Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the Generic class definitions into the include file, in preparation for pluggable upstreams
split out from #11327
Risk Level: Low (mostly only header changes)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a