upstreams: creating TCP and HTTP upstream via factory#11561
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
requested changes
Jun 12, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM with 1 comment.
/wait
| @@ -0,0 +1,35 @@ | |||
| #pragma once | |||
Member
There was a problem hiding this comment.
Do we actually need to reference these anywhere? In general we are trying to move away from the WKN files, so perhaps just inline the strings where they are used if possible?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
/azp list |
|
CI/CD Pipelines for this repository: |
Contributor
Author
|
/azp run envoy-presubmit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
Part 3 of envoyproxy#11327, using the new configuration to create the upstream connection pool. Risk Level: Medium (router refactor, intended as no-op) Testing: new unit tests Docs Changes: n/a Release Notes: pending final PR Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
Part 3 of envoyproxy#11327, using the new configuration to create the upstream connection pool. Risk Level: Medium (router refactor, intended as no-op) Testing: new unit tests Docs Changes: n/a Release Notes: pending final PR Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Part 3 of envoyproxy#11327, using the new configuration to create the upstream connection pool. Risk Level: Medium (router refactor, intended as no-op) Testing: new unit tests Docs Changes: n/a Release Notes: pending final PR Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Part 3 of envoyproxy#11327, using the new configuration to create the upstream connection pool. Risk Level: Medium (router refactor, intended as no-op) Testing: new unit tests Docs Changes: n/a Release Notes: pending final PR Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of #11327, using the new configuration to create the upstream connection pool.
Risk Level: Medium (router refactor, intended as no-op)
Testing: new unit tests
Docs Changes: n/a
Release Notes: pending final PR