std::string is replaced with absl::string_view in test for performance reasons.

[yashwant121]

A lot of the overhead std::string calls are replaced with absl::string_view
See #11287 for more details.

[yanavlasov]

This is undefined behavior. with_comma will be referencing dangling pointer on the line below. The ASAN run will likely fail after you fix format problem. Also there is no performance gain in doing this.

[yanavlasov]

Same thing here, undefined behavior.

[yanavlasov]

Quick look through the PR show a few instances of undefined behavior. Please run ASAN build on your change and address the problems it reports. A few of these changes need to reverted.

[jmarantz]

In general it should be safe to change formal-params to a function from string to string_view. However I think some of the other changes you've made look troublesome, per @yanavlasov's comments.

[jmarantz]

this looks suspicious.

[jmarantz]

/wait

[asraa]

Nice!!
Just a drive-by. The issue also meant to address some instances of casting a string-view to a string in a param that are unneeded, see #11287 (comment)