Skip to content

style: use type aliases#11601

Merged
lizan merged 10 commits into
envoyproxy:masterfrom
tomocy:style-use-type-alias
Jun 17, 2020
Merged

style: use type aliases#11601
lizan merged 10 commits into
envoyproxy:masterfrom
tomocy:style-use-type-alias

Conversation

@tomocy
Copy link
Copy Markdown
Contributor

@tomocy tomocy commented Jun 16, 2020

Commit Message: use type aliases
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
Fixes #11535
[Optional Deprecated:]

@htuch htuch requested a review from lizan June 16, 2020 13:28
@lizan
Copy link
Copy Markdown
Member

lizan commented Jun 16, 2020

Nice, can you fix the clang-tidy error? It's missing dependency from extension/common/wasm/BUILD to include/envoy/stats:scope_interface

tomocy added 9 commits June 17, 2020 21:04
Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: tomocy <tomocy.dev@gmail.com>
@tomocy tomocy force-pushed the style-use-type-alias branch from fdae7bf to e8aadcc Compare June 17, 2020 12:28
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/.

🐱

Caused by: #11601 was synchronize by tomocy.

see: more, trace.

Signed-off-by: tomocy <tomocy.dev@gmail.com>
@tomocy tomocy force-pushed the style-use-type-alias branch from e8aadcc to 0f719c4 Compare June 17, 2020 13:38
@tomocy tomocy marked this pull request as ready for review June 17, 2020 13:38
@tomocy tomocy requested a review from PiotrSikora as a code owner June 17, 2020 13:38
@lizan lizan merged commit ceb74cd into envoyproxy:master Jun 17, 2020
@tomocy tomocy deleted the style-use-type-alias branch June 18, 2020 07:37
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jun 24, 2020
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Fixes envoyproxy#11535 

Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu pushed a commit to songhu/envoy that referenced this pull request Jun 25, 2020
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Fixes envoyproxy#11535 

Signed-off-by: tomocy <tomocy.dev@gmail.com>
yashwant121 pushed a commit to yashwant121/envoy that referenced this pull request Jul 24, 2020
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Fixes envoyproxy#11535 

Signed-off-by: tomocy <tomocy.dev@gmail.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

style: use type aliases instead

2 participants