quiche: build GSO quic writer#11607
Merged
mattklein123 merged 12 commits intoenvoyproxy:masterfrom Jun 29, 2020
Merged
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @wu-bin @mattklein123 |
Member
|
Can you check tidy? /wait |
wu-bin
previously approved these changes
Jun 17, 2020
|
|
||
| envoy_cc_test( | ||
| name = "quic_core_batch_writer_batch_writer_test", | ||
| srcs = ["quiche/quic/core/batch_writer/quic_batch_writer_test.cc"], |
Contributor
There was a problem hiding this comment.
Do you need the "@envoy//bazel:linux" condition for this test?
Contributor
Author
There was a problem hiding this comment.
good point! It should need the condition. Fixed.
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
Fixed clang-tidy and added quic_core_batch_writer_batch_writer_test to CI tests. PTAL |
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
mattklein123
approved these changes
Jun 29, 2020
aimless404
pushed a commit
to aimless404/envoy
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Yifan Yang <needyyang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Zhang danzh@google.com
Build and test quic_gso_batch_writer under linux.
Added implementation for quic_udp_socket_platform_api.h
Risk Level: low, not in use
Testing: added quic_core_batch_writer_batch_writer_test.cc