LocalReply: fix a bug of invalid json format in grpc-message#11621
Merged
Conversation
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
For grpc requests, error message will write to grpc-message header.
LocalReplyConfig::body_format still applies. If it is JSON format, grpc-message header value will be in json too.
But there is a bug when json format is used, it generates an invalid json format as:
grpc-message: '{"code":401,"message":"Jwt is missing"%0A'
It should be:
grpc-message: '{"code":401,"message":"Jwt is missing"}'
Risk Level: Low
Testing: integration test
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
For grpc requests, error message will write to grpc-message header.
LocalReplyConfig::body_format still applies. If it is JSON format, grpc-message header value will be in json too.
But there is a bug when json format is used, it generates an invalid json format as:
grpc-message: '{"code":401,"message":"Jwt is missing"%0A'
It should be:
grpc-message: '{"code":401,"message":"Jwt is missing"}'
Risk Level: Low
Testing: integration test
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
For grpc requests, error message will write to grpc-message header.
LocalReplyConfig::body_format still applies. If it is JSON format, grpc-message header value will be in json too.
But there is a bug when json format is used, it generates an invalid json format as:
grpc-message: '{"code":401,"message":"Jwt is missing"%0A'
It should be:
grpc-message: '{"code":401,"message":"Jwt is missing"}'
Risk Level: Low
Testing: integration test
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Contributor
|
@qiwzhang The description here and the comment in the code mentioned JSON, yet the last character is stripped from body unconditionally. Was that intentional? This is breaking some Envoy gRPC responses for me, when the body is not JSON and is actually a binary payload. This stripping corrupts the response if the binary payload happens to end with 0x0A. |
Contributor
Author
|
Yes, we should check content_type to be JSON before trimming the last byte. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Zhang qiwzhang@google.com
For grpc requests, error message will write to grpc-message header.
LocalReplyConfig::body_format still applies. If it is JSON format, grpc-message header value will be in json too.
But there is a bug when json format is used, it generates an invalid json format as:
It should be:
Risk Level: Low
Testing: integration test