docs: fix description of cluster dns resolution counters #11305#11624
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jun 30, 2020
Merged
docs: fix description of cluster dns resolution counters #11305#11624mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
erikbos
force-pushed
the
docs-fix-dns-resolving
branch
from
7306561 to
fd35085
Compare
mattklein123
requested changes
Jun 18, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thank you for fixing. Can you possibly generalize a bit and/or maybe document what the stats mean in the docs specific to the clusters?
/wait
erikbos
force-pushed
the
docs-fix-dns-resolving
branch
from
ba07c48 to
be46ff0
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
Bot
added
stale
erikbos
force-pushed
the
docs-fix-dns-resolving
branch
from
cc93f86 to
8db1b15
Compare
Member
|
Thanks LGTM, can you fix DCO? You will need to squash and force push. /wait |
Signed-off-by: Erik Bos <erik@xs4all.nl>
erikbos
force-pushed
the
docs-fix-dns-resolving
branch
from
8db1b15 to
b613da9
Compare
mattklein123
approved these changes
Jun 29, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks! Will merge after the freeze is up tomorrow.
aimless404
pushed a commit
to aimless404/envoy
that referenced
this pull request
Jun 30, 2020
…11624) Signed-off-by: Erik Bos <erik@xs4all.nl> Signed-off-by: Yifan Yang <needyyang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: fix description of cluster dns resolution counters
Risk Level: Low
Docs Changes: fixes the description of cluster dns resolution counters based upon input from #11305
Fixes: #11305