build: fix go-control-plane mirror#11627
Merged
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
kyessenov
reviewed
Jun 17, 2020
| rule_dir, proto = rule.decode()[len('@envoy_api//'):].rsplit(':', 1) | ||
| input_dir = os.path.join(bazel_bin, 'external', 'envoy_api', rule_dir, 'linux_amd64_stripped', | ||
| proto + '%', IMPORT_BASE, rule_dir) | ||
| input_dir = os.path.join(bazel_bin, 'external', 'envoy_api', rule_dir, proto + '_', IMPORT_BASE, |
Contributor
There was a problem hiding this comment.
When I tried this locally, it could find the file in the old location. Was that some stale cache issue?
Member
Author
There was a problem hiding this comment.
I guess so, the a clean run result: https://github.com/lizan/go-control-plane/tree/11627
kyessenov
approved these changes
Jun 17, 2020
htuch
approved these changes
Jun 18, 2020
Contributor
|
Can we merge this? The bot pushed another bad commit envoyproxy/go-control-plane@e210385. |
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix go-control-plane broken by #11581, which changes the output directory layout.
Change the script to detect generated code change instead of detecting
envoy/apichange.Risk Level: Med
Testing: local
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Lizan Zhou lizan@tetrate.io