admission control: Implement thread-local controller#11628
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom Jun 24, 2020
Merged
admission control: Implement thread-local controller#11628mattklein123 merged 7 commits intoenvoyproxy:masterfrom
mattklein123 merged 7 commits intoenvoyproxy:masterfrom
Conversation
TODO: docs in next PR Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Member
|
Can you merge master to fix the build break and I will take a look? /wait |
Signed-off-by: Tony Allen <tony@allen.gg>
Member
Author
|
/wait-any |
Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123
requested changes
Jun 23, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice! LGTM with small comments.
/wait
Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Member
|
LGTM can you check tidy? /wait |
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Signed-off-by: Tony Allen <tony@allen.gg>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Signed-off-by: Tony Allen <tony@allen.gg> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation of the actual admission control logic as part of the breakup of #10985 (more context in that description). Since the filter is functional after this patch, the integration test has also been included.
Risk Level: Low. New filter.
Testing: Unit/integration tests.
Docs Changes: Will be included in next PR to prevent churn during review.
Release Notes: n/a
Progress (2/n) toward #9658