http1: pass some encoder flags as params#11704
Merged
zuercher merged 1 commit intoJun 24, 2020
Merged
Conversation
Commit Message: Some flags in the StreamEncoderImpl are only necessary for the duration of calls to encodeHeadersBase. Remove the fields and pass response status as an optional value rather than setting fields ahead of the encodeHeadersBase call. Additional Description: This refactoring was promised during review of envoyproxy#11458. This is a little more complicated than passing a never-chunk-encode bool since the behavior also covers content-length and may be partially disabled via the runtime flag added in 11458. Assigned risk level medium because its the h1 encoder. Risk Level: medium Testing: existing tests pass Doc Changes: n/a Release Note: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
alyssawilk
approved these changes
Jun 23, 2020
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
I really like the way this turned out. Thanks for the follow-up!
Member
Author
|
On the fence about whether I should just merge this or look for another reviewer. |
Member
|
I can take a quick look. |
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
Some flags in the StreamEncoderImpl are only necessary for the duration of calls to encodeHeadersBase. Remove the fields and pass response status as an optional value rather than setting fields ahead of the encodeHeadersBase call. Risk Level: medium Testing: existing tests pass Doc Changes: n/a Release Note: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
Some flags in the StreamEncoderImpl are only necessary for the duration of calls to encodeHeadersBase. Remove the fields and pass response status as an optional value rather than setting fields ahead of the encodeHeadersBase call. Risk Level: medium Testing: existing tests pass Doc Changes: n/a Release Note: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Some flags in the StreamEncoderImpl are only necessary for the
duration of calls to encodeHeadersBase. Remove the fields and
pass response status as an optional value rather than setting
fields ahead of the encodeHeadersBase call.
Additional Description: This refactoring was promised during
review of #11458. This is a little more complicated than
passing a never-chunk-encode bool since the behavior also
covers content-length and may be partially disabled via
the runtime flag added in 11458. Assigned risk level medium
because it's the h1 encoder.
Risk Level: medium
Testing: existing tests pass
Doc Changes: n/a
Release Note: n/a
Signed-off-by: Stephan Zuercher zuercher@gmail.com