Revert "pgv: update (#12025)"#12101
Closed
alyssawilk wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
Conversation
This reverts commit ca7dc53.
Member
|
@alyssawilk LGTM, but needs DCO fix. |
Member
|
This is actually a dupe of #12100. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ca7dc53.
Currently if one makes changes to the cluster proto, then runs fix_format, it copies the update from here to
generated_api_shadow/bazel/repository_locations.bzl and then breaks the build. I think this PR needs to be rolled forward with the same changes in generated_apo_shadow as here, and making sure the build works.
ERROR: /usr/local/google/home/alyssar/.cache/bazel/_bazel_alyssar/3a7172795bcbacd0230af40aaea95285/external/com_envoyproxy_protoc_gen_validate/BUILD:15:11: no such package '@com_github_lyft_protoc_gen_star//': The repository '@com_github_lyft_protoc_gen_star' could not be resolved and referenced by '@com_envoyproxy_protoc_gen_validate//:go_default_library'
Risk Level: low (reverting to prior build)
Testing: n/a
Docs Changes: n/a
cc @Shikugawa
cc @htuch we should probably fix it so the check_format script fails if the files are not in sync, yeah?