docs: add some verbiage for benchmark test rules#12121
Merged
Merged
Conversation
Signed-off-by: Phil Genera <pgenera@google.com>
Contributor
Author
|
Hey @antoniovicente, do you think this will help the next time someone is confused by the difference between a benchmark_binary and benchmark_test rule? |
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for improving this documentation, the benchmark/test duality has caused a fair bit of confusion.
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
jmarantz
reviewed
Jul 21, 2020
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
antoniovicente
approved these changes
Jul 22, 2020
jmarantz
approved these changes
Jul 22, 2020
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
Commit Message: Add documentation about benchmark test bazel rules. Additional Description: I'm trying to communicate that envoy_cc_benchmark_binary is for humans measuring performance, and envoy_benchmark_test is for machines running CI builds. Risk Level: None. Documentation only. Testing: automated spell check. Release Notes: N/A Signed-off-by: Phil Genera <pgenera@google.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add documentation about benchmark test bazel rules.
Additional Description: I'm trying to communicate that envoy_cc_benchmark_binary is for humans measuring performance, and envoy_benchmark_test is for machines running CI builds.
Risk Level: None. Documentation only.
Testing: automated spell check.
Release Notes: N/A