http: restore previous HeaderMap::remove() behavior#12244
Merged
mattklein123 merged 1 commit intomasterfrom Jul 23, 2020
Merged
http: restore previous HeaderMap::remove() behavior#12244mattklein123 merged 1 commit intomasterfrom
mattklein123 merged 1 commit intomasterfrom
Conversation
#12160 changed the behavior of remove() to not first look in the inline header map for a header. This is a subtle change in behavior that specifically breaks attempting to remove ":authority" via the "host" mapping. This restores that behavior and is thus a bug fix and low risk. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
cc @rgs1 |
jmarantz
approved these changes
Jul 23, 2020
Member
|
Didn't test internally, but LGTM. |
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
envoyproxy#12160 changed the behavior of remove() to not first look in the inline header map for a header. This is a subtle change in behavior that specifically breaks attempting to remove ":authority" via the "host" mapping. This restores that behavior and is thus a bug fix and low risk. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
envoyproxy#12160 changed the behavior of remove() to not first look in the inline header map for a header. This is a subtle change in behavior that specifically breaks attempting to remove ":authority" via the "host" mapping. This restores that behavior and is thus a bug fix and low risk. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12160 changed
the behavior of remove() to not first look in the inline
header map for a header. This is a subtle change in
behavior that specifically breaks attempting to remove
":authority" via the "host" mapping. This restores that
behavior and is thus a bug fix and low risk.
Risk Level: Low
Testing: New UT
Docs Changes: N/A
Release Notes: N/A