tidy: Fix some clang-tidy errors#12456
Closed
dio wants to merge 3 commits intoenvoyproxy:masterfrom
dio:tidy
Closed
tidy: Fix some clang-tidy errors#12456dio wants to merge 3 commits intoenvoyproxy:masterfrom dio:tidy
dio wants to merge 3 commits intoenvoyproxy:masterfrom
dio:tidy
Conversation
This makes sure we can run ./ci/run_clang_tidy.sh with RUN_FULL_CLANG_TIDY=1. Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
dio
commented
Aug 4, 2020
| BROWSE | ||
| /build | ||
| /build_* | ||
| *.bak |
Member
Author
There was a problem hiding this comment.
When running RUN_FULL_CLANG_TIDY=1 ./ci/run_clang_tidy.sh it produces bazelrc.bak.
dio
commented
Aug 4, 2020
| deps = CODEC_LIB_DEPS + [ | ||
| "//source/common/common:statusor_lib", | ||
| ], | ||
| deps = CODEC_LIB_DEPS, |
Member
Author
There was a problem hiding this comment.
This fixes the confusing missing common/common/statusor.h.
Member
Author
|
Hum, will merge #12458 then. |
dio
changed the title
dio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This fixes some clang-tidy errors (including
clang-diagnostic-error).Signed-off-by: Dhi Aurrahman dio@tetrate.io
Risk Level: Low
Testing: Manual, CI
Docs Changes: N/A
Release Notes: N/A