Skip to content

[WIP] docs/ci: Add link redirect checker to CI#13460

Closed
phlax wants to merge 1 commit intoenvoyproxy:masterfrom
phlax:docs-move-diff-ci
Closed

[WIP] docs/ci: Add link redirect checker to CI#13460
phlax wants to merge 1 commit intoenvoyproxy:masterfrom
phlax:docs-move-diff-ci

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Oct 9, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: docs/ci: Add link redirect checker to CI
Additional Description:

Now that we have added sphinxext-rediraffe we can use its tool to detect if a page has been moved in docs, without adding a redirect link for it

Risk Level: low
Testing: yep
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] touch #13436
[Optional Deprecated:]

@phlax phlax changed the title docs: Add link redirect checker to CI docs/ci: Add link redirect checker to CI Oct 9, 2020
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the docs-move-diff-ci branch from b5838f2 to 9f61d93 Compare October 9, 2020 08:07
@phlax phlax changed the title docs/ci: Add link redirect checker to CI [WIP] docs/ci: Add link redirect checker to CI Oct 9, 2020
@phlax phlax marked this pull request as draft October 9, 2020 08:51
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Oct 9, 2020

initial testing didnt trigger the diff error - need to test a bit further

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Oct 9, 2020

also, not entirely clear how this will work in terms of sphinx and our path mangling - my first reading of the source in rediraffe is that there is an assumption that sphinx is run from root - but this might be wrong. Either way i need to play with this a bit further outside of envoy repo (added https://github.com/phlax/sphinxdev)

@mattklein123 mattklein123 self-assigned this Oct 9, 2020
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 9, 2020
@mattklein123 mattklein123 removed the stale stalebot believes this issue/PR has not been touched recently label Dec 9, 2020
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 8, 2021

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 8, 2021
@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants