osx: minor os-independent changes required for OS X#1374
Merged
Conversation
mattklein123
approved these changes
Aug 2, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Add peer validation to ALTS implementation. **What this PR does / why we need it:** - Added the peer validation to ALTS implementation. - Manually tested with custom config and environment on GKE. **Special notes for your reviewer:** None **Release note:** None
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…g proto. (envoyproxy#1383) Automatic merge from submit-queue. Change target_service_accounts to peer_service_accounts in ALTS config proto. **What this PR does / why we need it**: - Change the target_service_accounts to peer_service_accounts in config proto, address some other comments. - Skip validation if peer_service_accounts is empty. - Manually tested with custom config (both validation success and fail) and environment on GKE. **Which issue this PR fixes**: Per request in envoyproxy#1374 . **Special notes for your reviewer**: None. **Release note**: None
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Copy the Java interfaces defining the [Cronet API](https://chromium.googlesource.com/chromium/src/+/master/components/cronet/android/api/src/org/chromium/net). Risk Level: Inexistant Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Charles Le Borgne <cleborgne@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Copy the Java interfaces defining the [Cronet API](https://chromium.googlesource.com/chromium/src/+/master/components/cronet/android/api/src/org/chromium/net). Risk Level: Inexistant Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Charles Le Borgne <cleborgne@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
…#1361) **Description** This PR implements comprehensive cross-namespace access support between AIServiceBackend and AIGatewayRoute resources, following Gateway API patterns with ReferenceGrant validation. **API Enhancements** - Added namespace field to AIGatewayRouteRuleBackendRef allowing cross-namespace backend references - Updated CRDs to include proper validation for the namespace field Enhanced documentation explaining ReferenceGrant requirements for cross-namespace access **ReferenceGrant Integration** - ReferenceGrant Validator: New component that validates cross-namespace references against ReferenceGrant resources - ReferenceGrant Controller: Watches ReferenceGrant resources and triggers reconciliation of affected AIGatewayRoutes when grants change - Automatic validation: Cross-namespace references are automatically validated at reconciliation time **Controller Updates** - Cross-namespace backend lookups: AIGatewayRoute controller now supports referencing AIServiceBackend resources in different namespaces - ReferenceGrant enforcement: Fails reconciliation with clear error messages when valid ReferenceGrant is missing - Event-driven reconciliation: ReferenceGrant changes trigger automatic reconciliation of affected routes **Comprehensive Testing** - Unit tests: Full coverage for ReferenceGrant validation logic, cross-namespace scenarios, and error cases - Integration tests: Controller tests validating cross-namespace backend references with and without ReferenceGrant - E2E test updates: Modified existing cross-namespace test to validate AIServiceBackend cross-namespace access with ReferenceGrant AIGatewayRouteBackendRefChange: ``` # AIGatewayRouteRuleBackendRef now supports: backendRefs: - name: my-backend namespace: other-namespace # NEW: Cross-namespace reference weight: 1 ``` Reference Grant Example: ``` apiVersion: gateway.networking.k8s.io/v1beta1 kind: ReferenceGrant metadata: name: allow-route-to-backend namespace: backend-ns spec: from: - group: aigateway.envoyproxy.io kind: AIGatewayRoute namespace: route-ns to: - group: aigateway.envoyproxy.io kind: AIServiceBackend ``` **Related Issues/PRs (if applicable)** close #1374 --------- Signed-off-by: siddharth1036 <siddharthshah1036@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some missing header #includes.
The static cast for to is needed because
uint64_tisunsigned long longin OS X. So the constant would have to be100ULL(with an #ifdef) to keep the compiler happy.The
std::movecalls inthread_local_impl.ccfix an apparent difference in strictness across compilers. (c.f. https://stackoverflow.com/questions/22018115/converting-stdunique-ptrderived-to-stdunique-ptrbase).Fixes #1371