health-check: fix grpc health check multiple resets#13855
Closed
adisuissa wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
health-check: fix grpc health check multiple resets#13855adisuissa wants to merge 1 commit intoenvoyproxy:masterfrom
adisuissa wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
asraa
reviewed
Nov 2, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thanks Adi! Is this possible to trigger via traffic/integration test?
Member
|
qq: what do you mean by double reset? Two resets can't happen on the same stream. Is this a test framework bug? |
Contributor
|
Agreed, if so, I wonder if @zasweq has some input on how to modify the fuzzer for this flow |
Contributor
|
Hey everyone, thanks for looking at this! Investigating now :)! |
Contributor
Author
|
#13780 might provide a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: health-check: fix grpc health check multiple resets
Additional Description:
Multiple resets caused failure accessing
request_encoder_after the health check was already reset.This PR verifies that
request_encoder_andclient_are valid before calling them.Risk Level: Low - adding a check
Testing: Added fuzz test.
Docs Changes: None.
Release Notes: None.
Platform Specific Features: None.
Fixes fuzz test: 26848
Signed-off-by: Adi Suissa-Peleg adip@google.com