osx: UUID generation, fix CLI arg parsing, fix trivial shutdown bug#1386
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Aug 3, 2017
Merged
osx: UUID generation, fix CLI arg parsing, fix trivial shutdown bug#1386mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
source/common/runtime: use libuuid for UUID generation on OS X source/server: fix crash on shutdown (when no config is specified) build: set HAVE_LONG_LONG to allow TCLAP to support uint64_T flags
mattklein123
reviewed
Aug 3, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, looks good. Tiny nit.
|
|
||
| std::string RandomGeneratorImpl::uuid() { | ||
| #ifdef __APPLE__ | ||
| // TODO (zuercher): factor out a sensible interface for UUID generation to make it easier |
Member
There was a problem hiding this comment.
trivial nit: no space between TODO and (...)
mattklein123
approved these changes
Aug 3, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
… tsan workflows (#1386) Description: This allows individually rerunning each suite in CI in the event of transient (typically connectivity) failures. Risk Level: Low Testing: CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
… tsan workflows (#1386) Description: This allows individually rerunning each suite in CI in the event of transient (typically connectivity) failures. Risk Level: Low Testing: CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source/common/runtime: use libuuid for UUID generation on OS X
source/server: fix crash on shutdown (e.g., when no config is specified)
build: set HAVE_LONG_LONG to allow TCLAP to support uint64_T flags
(Split out from #1348, in support of #128.)