backport to 1.15: connection: Remember transport socket read resumption requests and replay them when re-enabling read. (#13772)#14073
Closed
cpakulski wants to merge 2 commits intoenvoyproxy:release/v1.15from
Closed
Conversation
…play them when re-enabling read. (envoyproxy#13772) Fixes SslSocket read resumption after readDisable when processing the SSL record that contains the last bytes of the HTTP message Signed-off-by: Antonio Vicente <avd@google.com> Signed-off-by: antonio <avd@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
| write_end_stream_(false), current_write_end_stream_(false), dispatch_buffered_data_(false) { | ||
| // Treat the lack of a valid fd (which in practice only happens if we run out of FDs) as an OOM | ||
| // condition and just crash. | ||
| RELEASE_ASSERT(SOCKET_VALID(ConnectionImpl::ioHandle().fd()), ""); |
Contributor
There was a problem hiding this comment.
The removal of this RELEASE_ASSERT is not part of the patch, it's causing test failures.
| @@ -0,0 +1,446 @@ | |||
| #pragma once | |||
Contributor
There was a problem hiding this comment.
See if this header is needed. Seems that it isn't used.
Contributor
|
See #14173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: connection: Remember transport socket read resumption requests and replay them when re-enabling read.
Additional Description: Fixes SslSocket read resumption after readDisable when processing the SSL record that contains the last bytes of the HTTP message
Risk Level: low
Testing: new unit and integration tests
Docs Changes: n/a
Release Notes: added
Platform Specific Features: n/a
Fixes #12304