Skip to content

[test] fix legacy default #14101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asraa merged 1 commit into from
Nov 23, 2020
Merged

[test] fix legacy default #14101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bazel/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,8 @@ config_setting(
)

config_setting(
name = "enable_new_codecs_in_integration_tests",
values = {"define": "use_new_codecs_in_integration_tests=true"},
name = "enable_legacy_codecs_in_integration_tests",
values = {"define": "use_new_codecs_in_integration_tests=false"},
)

cc_proto_library(
Expand Down
6 changes: 3 additions & 3 deletions bazel/envoy_select.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ def envoy_select_wasm_wasmtime(xs):
"//conditions:default": [],
})

# Select the given values if use legacy codecs in test is on in the current build.
# Select the given values by default and remove if use new codecs are disabled for current build.
def envoy_select_new_codecs_in_integration_tests(xs, repository = ""):
return select({
repository + "//bazel:enable_new_codecs_in_integration_tests": xs,
"//conditions:default": [],
repository + "//bazel:enable_legacy_codecs_in_integration_tests": [],
"//conditions:default": xs,
})