event: Extract DispatcherBase interface#14446
event: Extract DispatcherBase interface#14446antoniovicente merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Antonio Vicente <avd@google.com>
akonradi
left a comment
akonradi
left a comment
There was a problem hiding this comment.
Looks good. Have you tried refactoring any of the impl classes returned by the dispatcher to use DispatcherBase yet?
|
|
||
| /** | ||
| * Abstract event dispatching loop. | ||
| * Minimal interface to the disptching loop used to create low-level primitives. See Dispatcher |
There was a problem hiding this comment.
nit: sp on dispatching is causing your format failure
|
This makes sense to me but this is small enough that do we want to just do this change in another change that actually needs it? Up to you all. /wait |
Signed-off-by: Antonio Vicente <avd@google.com>
@akonradi Thoughts? Do you want to include this in a PR that adds a way to create scaled timers via the dispatcher? |
|
Given that this is already approved, I say let's get it in now. No need to make the next PR bigger. |
|
Thanks Matt. |
Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Antonio Vicente <avd@google.com>
This reverts commit e73281d.
3 participants
Commit Message:
event: Extract DispatcherBase interface
This new interface allows us to more safely build primitives like ScaledTimers which are themselves built on top of low-level
event loop primitives like Timers which are themselves created via the dispatcher interface.
Additional Description:
Risk Level: n/a interface only change
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Issue #14401