admin: add /routes endpoint#1450
admin: add /routes endpoint#1450junr03 wants to merge 1 commit intosingleton-manager-route-configfrom
Conversation
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
This will be useful... quick question.
|
|
||
| if (route_config_provider_manager == nullptr) { | ||
| response.add("There are no dynamic route tables currently loaded."); | ||
| return Http::Code::OK; |
There was a problem hiding this comment.
Can we also dump the static routes? Or is the idea that by dumping config that we already have that?
There was a problem hiding this comment.
Yep, exactly. Dumping the config gives you the static routes.
There was a problem hiding this comment.
OK. BTW, I would strongly recommend saving the proto as seen by rds_api_impl.cc after #1441 instead of the JSON. This will make this forward compatible with the v2 work and it's super easy to print protos to a human readable format (some_proto.DebugString()).
There was a problem hiding this comment.
Yes, agreed, let's switch everything to proto saving and dumping. This change should get rebased on that change as well as the singleton change.
|
closing until #1449 lands. |
This removes somewhat controversial intermediate step of sorting heap profile buckets and fixes issue where heap profiles could get truncated sometimes. See github issue envoyproxy#1450.
3 participants
WIP - add a /routes endpoint to print out loaded dynamic route tables
TODO: