transport_sockets: removed well_known_names.h file.#14751
transport_sockets: removed well_known_names.h file.#14751cpakulski wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
|
For x-ref, this is the issue Matt was referring to #7238 |
cpakulski
requested review from
PiotrSikora,
alyssawilk,
asraa,
ggreenway,
htuch,
lizan and
mattklein123
as code owners
|
Thanks @asraa for pointing to the original issue. I will update the PR description with the issue number. |
| if (!config.has_transport_socket()) { | ||
| if (config.has_hidden_envoy_deprecated_tls_context()) { | ||
| transport_socket.set_name(Extensions::TransportSockets::TransportSocketNames::get().Tls); | ||
| transport_socket.set_name("envoy.transport_sockets.tls"); |
There was a problem hiding this comment.
I think the changes to adding the names inline in name() methods in source/extensions make sense to me. Here and in source/server, references to tls/raw_buffer names seem like they should refer to a common string, but it doesn't seem like there's a good place for that unless it exists in common/network somewhere.
@mattklein123 @htuch do you have ideas or should this just stay as is?
If it should stay as is, PR LGTM.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
Bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
2 participants
Commit Message:
Removed transport_sockets/well_known_names.h file.
Additional Description:
This is as per comment here: #13112 (comment)
Risk Level: Low
Testing: Make sure that all unit and integration tests pass
Docs Changes: No
Release Notes: No
Platform Specific Features:
Partially fixes: #7238