Skip to content

chore: correct grammar in upstream/connection_pooling.rst#14846

Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
spacewander:grammar
Jan 31, 2021
Merged

chore: correct grammar in upstream/connection_pooling.rst#14846
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
spacewander:grammar

Conversation

@spacewander
Copy link
Copy Markdown
Contributor

Signed-off-by: spacewander spacewanderlzx@gmail.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message:
Additional Description:
Risk Level: N/A
Testing: N/A
Docs Changes: Yes
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@moderation
Copy link
Copy Markdown
Contributor

This is the second single character spelling PR you have submitted. Please bundle these spelling PRs into a larger PR. This approach to spelling changes appears to be a method of attempting to game PR contribution statistics.

@spacewander
Copy link
Copy Markdown
Contributor Author

@moderation
I submitted this because I start to read the doc of Envoy recently. The problem is discovered separately. Maybe Envoy can introduce some doc-change limitation to the contributors.

I have been submitted several PRs to Envoy before, including new feature like: #14486.

I also have been submitted several issues before. Even some of them didn't get any reply from the Envoy developers:
#14488
#14465

I don't even have interested to mention Envoy in my profile:
https://github.com/spacewander

So is it the official way to treat the non-Envoy official contributor? It seems Envoy doesn't do much better than Nginx.

@mattklein123
Copy link
Copy Markdown
Member

So is it the official way to treat the non-Envoy official contributor? It seems Envoy doesn't do much better than Nginx.

@spacewander we have had issues in the past with people doing fixes like this in order to game commit stats, as @moderation said. Sorry for the confusion, your contributions are appreciated. Thank you!

@mattklein123 mattklein123 merged commit d767f40 into envoyproxy:main Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants