Add a cluster metadata access logger formatter#14911
Add a cluster metadata access logger formatter#14911yanavlasov merged 7 commits intoenvoyproxy:mainfrom
Conversation
|
/assign yanavlasov |
There was a problem hiding this comment.
I'm actually not sure that this is not implemented for TCP, I just copied it from the dynamic metadata documentation.
I can understand why HTTP filter setting metadata would not be implemented for TCP for the dynamic metadata.
For cluster metadata, however, the question is whether the stream info contains any metadata for TCP clusters - @yanavlasov do you know how do that works?
There was a problem hiding this comment.
This metadata is for filters but I do not know if this applies to the TCP proxy as well. I will ask someone to look at this PR who might know.
From documentation it looks like it would not be applicable to the TCP proxy.
|
/review yanavlasov |
|
@itamarkam please merge main. I think it should solve the issue with the "verify examples" check. |
|
/wait |
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Done. |
|
@yanavlasov @itamarkam should we start implementing these formatters as extensions in the future (see #14512)? We could even transform this one into an extension (happy to volunteer), to ensure the list of core formatters doesn't keep growing. |
|
FWIW, I bumped into this change because I still carry a patch internally for #12991 while I move all our clusters into using that formatter implemented as an extension... so I had to rebase my in-house patch after this one (not a big deal, but another reason to use extensions!). |
3 participants
Commit Message: Add cluster metadata access logger formatter
Additional Description: Allows logging cluster metadata by using CLUSTER_METADATA(...)
Risk Level: Low (adding a new feature)
Testing: Unit tests
Docs Changes: Added documentation in docs/root/configuration/observability/access_log/usage.rst (very similar to the DYNAMIC_METADATA)
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]
@omriz