wasm: fix crash on HTTP callout to a bad cluster.#15311
Merged
lizan merged 2 commits intoenvoyproxy:mainfrom Mar 10, 2021
Merged
wasm: fix crash on HTTP callout to a bad cluster.#15311lizan merged 2 commits intoenvoyproxy:mainfrom
lizan merged 2 commits intoenvoyproxy:mainfrom
Conversation
Fixes envoyproxy#14878, proxy-wasm/proxy-wasm-cpp-sdk#81. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
mattklein123
reviewed
Mar 4, 2021
Comment on lines
+722
to
+723
| // Simulate code path for "no healthy host for HTTP connection pool" inline callback. | ||
| cb.onSuccess(request, std::move(response)); |
Member
There was a problem hiding this comment.
To your original question as to why this is "success" vs. failure I think it's just historical. It probably should be a failure in the async client case.
Contributor
Author
There was a problem hiding this comment.
What's even more surprising is that AsyncClient::send() calls onSuccess() inline, before returning nullptr.
Member
There was a problem hiding this comment.
Again, historical. Happy to have this code be improved/changed if you are interested.
Contributor
Author
|
/backport |
repokitteh-read-only
Bot
added
the
backport/review
lizan
approved these changes
Mar 10, 2021
Shikugawa
added
backport/approved
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 10, 2021
Fixes envoyproxy#14878, proxy-wasm/proxy-wasm-cpp-sdk#81. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Shikugawa <rei@tetrate.io>
Shikugawa
added a commit
that referenced
this pull request
Mar 15, 2021
Fixes #14878, proxy-wasm/proxy-wasm-cpp-sdk#81. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Shikugawa <rei@tetrate.io> Co-authored-by: Piotr Sikora <piotrsikora@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14878, proxy-wasm/proxy-wasm-cpp-sdk#81.
Signed-off-by: Piotr Sikora piotrsikora@google.com