Using common member variables in integration tests#1532
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Aug 24, 2017
Merged
Using common member variables in integration tests#1532mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
mattklein123
approved these changes
Aug 24, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
you are my hero. thanks!
Merged
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** The compiled binaries report the Git SHA in the version. For example, the `v0.4.0` downloaded CLI prints this: ``` $ ./aigw-darwin-arm64 version Envoy AI Gateway CLI: ad5f75e ``` This is not particularly useful to users, so this change updates how versions are encoded in the binary: ``` # Binary compiled from a tag -> version is just the name of the tag: $ ./aigw-darwin-arm64 version Envoy AI Gateway CLI: 0.4.0 # Binary is compiled from a non-tag commit -> version shows the SHA, the closest tag and the number of commits ahead of that tag: $ ./aigw-darwin-arm64 version Envoy AI Gateway CLI: c662744d (v0.4.0, +8) ``` Users insterested in the exact Git SHA can still get it with: ``` $ go version -m ./aigw-darwin-arm64 | grep vcs build vcs=git build vcs.revision=c662744d6485424945d41d044797e3883c91605a build vcs.time=2025-11-11T14:24:44Z build vcs.modified=false ``` **Related Issues/PRs (if applicable)** N/A **Special notes for reviewers (if applicable)** N/A Signed-off-by: Ignasi Barrera <nacx@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1518
The first step to reducing boilerplate is to use member variables so we can have helper functions.
This is a test only change and should be a functional no-op, just using consistent member variables for 80% of the test (those with single request and response)