router: set upstream connection filter state in downstream request stream info#15543
router: set upstream connection filter state in downstream request stream info#15543snowp merged 6 commits intoenvoyproxy:mainfrom
Conversation
…ream info Signed-off-by: Elisha Ziskind <eziskind@google.com>
|
@snowp @ggreenway Could you take a look at this since it's related to #10457? |
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks! Just one small nit
Signed-off-by: Elisha Ziskind <eziskind@google.com>
|
Seems like there is an unrelated failure in clang tidy, can you try merging main? |
Signed-off-by: Elisha Ziskind <eziskind@google.com>
Signed-off-by: Elisha Ziskind <eziskind@google.com>
Done. Also fixed an unrelated format issue in test/test_common/environment.cc |
Signed-off-by: Elisha Ziskind <eziskind@google.com>
Hmm, looks like running "tools/code_format/check_format.py fix test/test_common/environment.cc" generated an unacceptable change, so I'm reverting that. |
|
Seems like the clang tidy errors are being picked up since this changes code close to the code that fails clang tidy. Do you think you can take a look to see if they are easy to fix? I think this PR will be blocked on them being resolved |
Signed-off-by: Elisha Ziskind <eziskind@google.com>
Ok, trying again. It seems like a clang-tidy false positive where it incorrectly thinks that there is a null pointer access. I added a NOLINT comment to suppress this. |
@lizan fyi about this false-positive clang-tidy error. |
3 participants
This makes it possible to lookup upstream connection filter state from a downstream HTTP access log, similar to #10458 which does the same for upstream HTTP access logs.
Risk Level: low
Testing: unit tests
Fixes #13166
Signed-off-by: Elisha Ziskind eziskind@google.com