Reducing boilerplate code in the integration tests#1556
Merged
alyssawilk merged 2 commits intoenvoyproxy:masterfrom Aug 28, 2017
Merged
Reducing boilerplate code in the integration tests#1556alyssawilk merged 2 commits intoenvoyproxy:masterfrom
alyssawilk merged 2 commits intoenvoyproxy:masterfrom
Conversation
| } | ||
| }] | ||
| }, | ||
| { |
Member
There was a problem hiding this comment.
Is this config (and tests) removed because it is duplicated?
Contributor
Author
There was a problem hiding this comment.
Oops - updated PR description. I also removed the duplicate TCP proxy tests (and config) because I noticed them. Happy to split them out but they're at least called out in the PR description now!
mattklein123
approved these changes
Aug 28, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Add a shadow workflow that uses a remote execution cluster for the iOS build. Risk Level: LOW Testing: We previously built envoy mobile on the remote execution cluster. Signed-off-by: Ulf Adams <ulf@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Add a shadow workflow that uses a remote execution cluster for the iOS build. Risk Level: LOW Testing: We previously built envoy mobile on the remote execution cluster. Signed-off-by: Ulf Adams <ulf@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of my TODOs for #1518
Let me know what you think!
Also removing TCP proxy tests and config from ingetegration_test.cc as I moved them to test/integration/tcp_proxy_integration_test.cc in #1183