BaseIntegrationTest -> HttpIntegrationTest#1618
BaseIntegrationTest -> HttpIntegrationTest#1618alyssawilk merged 7 commits intoenvoyproxy:masterfrom
Conversation
| } | ||
|
|
||
| void BaseIntegrationTest::sendRequestAndWaitForResponse(Http::TestHeaderMapImpl& request_headers, | ||
| HttpIntegrationTest::HttpIntegrationTest(Http::CodecClient::Type client_protocol, |
There was a problem hiding this comment.
Do you want to split/rename to http_integation_test.cc etc?
There was a problem hiding this comment.
Sure. I figured diffs would be easier this way, but either way it'll be separate commits. Will do in the next push :-)
There was a problem hiding this comment.
Split out but I'll admit I was lazy cleaning up includes and libraries, given it's test code.
Feel free to tell me to be non-lazy if you care about such things, otherwise I'll just make sure the OSX build doesn't choke.
There was a problem hiding this comment.
My preference is to try to keep the test code cleanly as we do with the production code, if you don't mind doing those cleanups. If you are too busy I would potentially just add a TODO for the cleanup.
|
|
||
| namespace Envoy { | ||
| class Http2IntegrationTest : public BaseIntegrationTest, | ||
| class Http2IntegrationTest : public HttpIntegrationTest, |
There was a problem hiding this comment.
While we're thinking about refactoring, protocols and programmatic generation of config, what are your thoughts about being able to independently set the downstream/upstream protocol? Today, upstream is essentially a property of how we setup the config file, rather than test driven. It seems that (just like in GFE), we want to be able to treat these both as first class properties in tests.
There was a problem hiding this comment.
Yeah, I think that one may have to want until backend config is proto-driven, but I planned to experiment with it next.
| hdrs = [ | ||
| "http_integration.h", | ||
| ], | ||
| data = ["//test/common/runtime:filesystem_test_data"], |
There was a problem hiding this comment.
Why is this needed? I don't remember history here.
**Description** This commit adds indexing for referencegrants. The indexing key uses To Kind + namespace in referencegrant for indexing which would help fetch only related referencegrants given aiservicebackend and namespace. **Related Issues/PRs (if applicable)** Closes #1375 --------- Signed-off-by: siddharth1036 <siddharthshah1036@gmail.com>
3 participants
Moving the bulk of HTTP/H2-specific logic into a subclass of BaseIntegrationTest
Also moving client_protocol_ into the new HttpIntegrationTest