config: support for DiscoveryResponse nonces in gRPC Subscription.#1647
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Sep 14, 2017
Merged
config: support for DiscoveryResponse nonces in gRPC Subscription.#1647htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Member
Author
|
This has #1645 as well in the commit history, will remove once that is merged, throwing PR out for review while Travis is stuck. |
This brings in a bunch of ADS changes, route decorators and the response nonce. This will also unblock envoyproxy#1632.
Member
Author
|
Rebased, now good to review in entirety. |
mattklein123
approved these changes
Sep 14, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Bugfix. The AsyncDemoFilter would hold headers-only responses indefinitely, leading to a timeout. Encountered this testing error responses with the example apps. Risk Level: Low Testing: Local & CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Bugfix. The AsyncDemoFilter would hold headers-only responses indefinitely, leading to a timeout. Encountered this testing error responses with the example apps. Risk Level: Low Testing: Local & CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a bonus fix to the attempt stats in Subscriptions and related tests.