[WIP] docs: Use genrule to generate extension db#16481
Closed
phlax wants to merge 4 commits into
Closed
Conversation
repokitteh-read-only
Bot
added
the
deps
phlax
force-pushed
the
docs-gen-extension-db
branch
2 times, most recently
from
d88e5bb to
c64efac
Compare
phlax
changed the title
htuch
reviewed
May 14, 2021
Member
There was a problem hiding this comment.
This seems kind of hacky; is this going to be robust?
htuch
reviewed
May 14, 2021
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM, is this relpath business the solution to finding SRCDIR?
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
docs-gen-extension-db
branch
from
c64efac to
0bdc12e
Compare
phlax
requested review from
PiotrSikora,
Shikugawa,
alyssawilk,
antoniovicente,
asraa,
cpakulski,
dio,
ggreenway,
jmarantz,
junr03,
lambdai,
lizan,
mattklein123,
snowp,
yanavlasov and
zuercher
as code owners
phlax
changed the title
Member
Author
|
awaiting #16496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: docs: Use genrule to generate extension db
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]