build: fix mac build with xcode 12#16514
Merged
Merged
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Contributor
Author
|
@antoniovicente @alyssawilk @lizan can you PTAL? |
alyssawilk
approved these changes
May 18, 2021
| prev_bytes_to_drain_ > 0 | ||
| ? prev_bytes_to_drain_ | ||
| : std::min(buffer.length(), actual_frame_size_to_use_ - frame_overhead_size_); | ||
| : std::min<size_t>(buffer.length(), actual_frame_size_to_use_ - frame_overhead_size_); |
Contributor
There was a problem hiding this comment.
cc @yihuazhang
I think this should have been std::min<uint64_t>. We'll revisit in #16488
Thanks for the build fix.
ntgsx92
pushed a commit
to ntgsx92/envoy
that referenced
this pull request
May 18, 2021
Commit Message: fix mac build with xcode 12 Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Sixiang Gu <sgu@twitter.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Commit Message: fix mac build with xcode 12 Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have upgraded to xcode 12 and build is failing. This PR fixes it.
Commit Message: fix mac build with xcode 12
Additional Description:
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]