Refactor WatermarkFactory::create to WatermarkFactory::createBuffer.#17108
Merged
antoniovicente merged 2 commits intoenvoyproxy:mainfrom Jun 24, 2021
Merged
Refactor WatermarkFactory::create to WatermarkFactory::createBuffer.#17108antoniovicente merged 2 commits intoenvoyproxy:mainfrom
antoniovicente merged 2 commits intoenvoyproxy:mainfrom
Conversation
we'll be creating BufferMemoryAccounts from the factories as well. Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
KBaichoo
requested review from
asraa,
cpakulski,
ggreenway and
lizan
as code owners
Contributor
Author
|
/assign @antoniovicente |
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Looks good otherwise.
/wait
| using InstancePtr = std::unique_ptr<Instance>; | ||
|
|
||
| /** | ||
| * A factory for creating buffers which call callbacks when reaching high and low watermarks. |
Contributor
There was a problem hiding this comment.
I think you should keep this class comment
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
antoniovicente
approved these changes
Jun 23, 2021
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
…ffer. (envoyproxy#17108) WatermarkFactory will be used to create BufferMemoryAccounts in addition to Buffers. Signed-off-by: Kevin Baichoo <kbaichoo@google.com> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…ffer. (envoyproxy#17108) WatermarkFactory will be used to create BufferMemoryAccounts in addition to Buffers. Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor WatermarkFactory::create to WatermarkFactory::createBuffer. we'll be creating BufferMemoryAccounts from the factories as well.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
Commit Message: Refactor WatermarkFactory::create to WatermarkFactory::createBuffer.
Additional Description: See #17093 (comment)
Risk Level: low
Testing: Ran tests
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA
Related Issue #15791