Skip to content

backport: v1.17 - ci: Publish artefacts for the exactly required docker images (#17080) #17159

Merged
lizan merged 1 commit intoenvoyproxy:release/v1.17from
phlax:v1.17-docker-save
Jul 2, 2021
Merged

backport: v1.17 - ci: Publish artefacts for the exactly required docker images (#17080) #17159
lizan merged 1 commit intoenvoyproxy:release/v1.17from
phlax:v1.17-docker-save

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jun 25, 2021

Commit Message: backport: v1.17 - ci docker save(#17080)
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@dmitri-d
Copy link
Copy Markdown
Contributor

This looks ok to me. Does this need to be ported to 1.18 too?

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 29, 2021

Does this need to be ported to 1.18 too?

yep, i think it will want to be backported to all of the active branches

@dmitri-d
Copy link
Copy Markdown
Contributor

@phlax: does this require any other changes (possibly in other repositories) other than the ones in this PR?

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 30, 2021

does this require any other changes (possibly in other repositories) other than the ones in this PR?

it requires the same change to be applied to all of the release branches, ill create PRs shortly

@phlax phlax changed the title [WIP/TESTING] backport: v1.17 - ci docker save(#17080) backport: v1.17 - ci: Publish artefacts for the exactly required docker images (#17080) Jun 30, 2021
@phlax phlax marked this pull request as ready for review June 30, 2021 14:04
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jun 30, 2021

in addition to this one, ive added backports for:

v1.15 did not require it as it doesnt have verify_examples

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 2, 2021

@dmitri-d @lizan i think this should be good to merge

@lizan lizan merged commit 25b1473 into envoyproxy:release/v1.17 Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants