rocketmq: fix protobuf import path#17810
rocketmq: fix protobuf import path#17810johanbrandhorst wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
|
Hi @johanbrandhorst, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
envoyproxy#17796 moved rocketmq to `contrib`, but forgot to update the relative import in v4alpha/rocketmq_proxy.proto as it did for v3/rocketmq_proxy.proto. Update the import to fix the Protobuf generation. This was discovered when trying to build latest envoy with `buf`. Would you be interested in adding some `buf` steps to your CI to avoid this sort of issue in the future? Signed-off-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
johanbrandhorst
force-pushed
the
patch-1
branch
from
32cebed to
67cfde5
Compare
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks. I think the issue is we don't actually build v4alpha right now and these are all going to get deleted soon I think so probably not worth it to add anything to CI. Thanks for fixing.
|
Hmm, looks like format is failing probably due to the proto format code not working quite right in v4alpha generation. @htuch is this worth fixing since it's not failing our CI and we are going to remove soon? /wait |
|
@mattklein123 yeah, v4alpha is not long for this world in the repo, I'll get around to removing after #17724 lands. |
|
@johanbrandhorst I've been working on adding buf to CI actually! #17793 It actually caught this same issue, you beat me to it: https://dev.azure.com/cncf/envoy/_build/results?buildId=86148&view=logs&j=b4781dd6-e8d1-56ca-824c-e97e27bdf79d&t=45617383-04d6-5506-f07f-2ba46008d9c7&l=30168 Also, the pre-push hooks seemed to have some trouble when I tried to make this same change on my own fork. |
|
Looks like this was fixed on main, I'll close this PR. |
4 participants
#17796 moved rocketmq to
contrib, but forgot to update the relative import in v4alpha/rocketmq_proxy.proto as it did for v3/rocketmq_proxy.proto. Update the import to fix the Protobuf generation.This was discovered when trying to build latest envoy with
buf. Would you be interestedin adding some
bufsteps to your CI to avoid this sort of issue in the future?Commit Message: rocketmq: fix protobuf import path
Additional Description: #17796 moved rocketmq to
contrib, but forgot to update the relative import in v4alpha/rocketmq_proxy.proto as it did for v3/rocketmq_proxy.proto. Update the import to fix the Protobuf generation.Risk Level: Low
Testing: Existing tests
Docs Changes: None
Release Notes: None