Skip to content

tools: remove gogo/protobuf from buf dependencies#18042

Closed
adisuissa wants to merge 3 commits into
envoyproxy:mainfrom
adisuissa:remove_gogo_from_buf
Closed

tools: remove gogo/protobuf from buf dependencies#18042
adisuissa wants to merge 3 commits into
envoyproxy:mainfrom
adisuissa:remove_gogo_from_buf

Conversation

@adisuissa
Copy link
Copy Markdown
Contributor

Commit Message: tools: remove gogo/protobuf from buf dependencies
Additional Description:
Following discussion starting at comment, this is the first step of removing gogo/protobuf from the buf dependencies.
It seems that it was previously added to test breaking changes against old PRs that used gogo/protobuf.

Risk Level: Low - impacts CI only
Testing: N/A.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.

Signed-off-by: Adi Suissa-Peleg adip@google.com

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa
Copy link
Copy Markdown
Contributor Author

Verifying CI first.
/wait

@adisuissa adisuissa marked this pull request as draft September 9, 2021 15:57
@adisuissa adisuissa removed the waiting label Sep 9, 2021
@adisuissa
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:

🐱

Caused by: a #18042 (comment) was created by @adisuissa.

see: more, trace.

@dmitri-d
Copy link
Copy Markdown
Contributor

dmitri-d commented Sep 9, 2021

This is awesome, tyvm for dealing with this.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 10, 2021
@moderation
Copy link
Copy Markdown
Contributor

/notstale

@adisuissa can we get this updated and merged?

@github-actions github-actions Bot removed the stale stalebot believes this issue/PR has not been touched recently label Oct 12, 2021
@adisuissa
Copy link
Copy Markdown
Contributor Author

I've looked into this and it turns out that buf is adding all the transitive dependencies into the lock files (in our case promethues seems to be dependent on gogo/protobuf). This shouldn't be much of an issue, as it is only a file used internally by buf (not a direct dependency of Envoy).
In any case, due to this and other reasons, I'm trying to see if we can use an alternative to buf.
I think we can close this for now, but leaving it up to you @moderation.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 12, 2021
@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants