tools: remove gogo/protobuf from buf dependencies#18042
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
Verifying CI first. |
|
/retest |
|
Retrying Azure Pipelines: |
|
This is awesome, tyvm for dealing with this. |
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
/notstale @adisuissa can we get this updated and merged? |
|
I've looked into this and it turns out that buf is adding all the transitive dependencies into the lock files (in our case |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Commit Message: tools: remove gogo/protobuf from buf dependencies
Additional Description:
Following discussion starting at comment, this is the first step of removing gogo/protobuf from the buf dependencies.
It seems that it was previously added to test breaking changes against old PRs that used gogo/protobuf.
Risk Level: Low - impacts CI only
Testing: N/A.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.
Signed-off-by: Adi Suissa-Peleg adip@google.com