stats: use re2 for prometheus metrics sanitization.#18110
Merged
ggreenway merged 1 commit intoenvoyproxy:mainfrom Sep 14, 2021
Merged
stats: use re2 for prometheus metrics sanitization.#18110ggreenway merged 1 commit intoenvoyproxy:mainfrom
ggreenway merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
jmarantz
approved these changes
Sep 14, 2021
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
Thanks! This should help speed up the Prometheus sink.
/assign-from @envoyproxy/senior-maintainers
|
@envoyproxy/senior-maintainers assignee is @ggreenway |
ggreenway
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io
Commit Message: stats: use re2 for prometheus metrics sanitization instead of std::regex. This is a follow up on #17357.
Additional Description: NA
Risk Level: low
Testing: unit tests
cc @jmarantz