Skip to content

ssl: update BoringSSL to ae9f0616 (3202).#1881

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
PiotrSikora:boringssl_m62
Oct 17, 2017
Merged

ssl: update BoringSSL to ae9f0616 (3202).#1881
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
PiotrSikora:boringssl_m62

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Comment thread source/common/ssl/context_impl.cc Outdated
// for (const GENERAL_NAME* san : *san_names) {
for (size_t i = 0; i < sk_GENERAL_NAME_num(san_names.get()); i++) {
const GENERAL_NAME* san = sk_GENERAL_NAME_value(san_names.get(), i);
for (const GENERAL_NAME* san : san_names.get()) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; much nicer this way

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, I have to revert that, since new BoringSSL isn't in the build image yet.

New BoringSSL is not installed into the build image just yet.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@mattklein123 mattklein123 merged commit 44d539c into envoyproxy:master Oct 17, 2017
Copilot AI added a commit that referenced this pull request Apr 30, 2026
Copilot AI added a commit that referenced this pull request May 1, 2026
phlax added a commit that referenced this pull request May 1, 2026
this is a good idea anyway (surprised it works unpacking where it does)

hopefully finally fix libc++ false positives (alert #1881)

cleanup previous attempts

Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants