runtime: flipping envoy.reloadable_features.remove_legacy_json#18861
Merged
alyssawilk merged 6 commits intoenvoyproxy:mainfrom Nov 8, 2021
Merged
runtime: flipping envoy.reloadable_features.remove_legacy_json#18861alyssawilk merged 6 commits intoenvoyproxy:mainfrom
alyssawilk merged 6 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
asraa
suggested changes
Nov 2, 2021
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thank you!
I think this can be removed with the default change
envoy/test/common/json/json_fuzz_test.cc
Line 17 in 676ec2a
Contributor
Author
|
/wait test failure is real |
Contributor
|
Hmm checking on this -- I'm trying to see if I can repro something similar in the unit tests and go from there |
Contributor
Author
|
Looks like a difference in error messages - will send an update soon and
you can TAL
…On Tue, Nov 2, 2021 at 1:43 PM asraa ***@***.***> wrote:
Hmm checking on this -- I'm trying to see if I can repro something similar
in the unit tests and go from there
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18861 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AELALPNQQFALDALAAC3LGR3UKAWOBANCNFSM5HGPLFDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Contributor
Author
|
/wait needs coverage for old code |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
ok, finally! |
asraa
approved these changes
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added the code to switch json libraries over in #14467
The removal is tracked by #4705 and smoke tested (#18451)
Risk Level: Medium for folks using json
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes #18451